Add rules : prohibited_with, prohibited_with_all, prohibited_without, prohibited_without_all + Modify rules In + NotIn to manage array values #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… prohibited_without_all Modify rules In + NotIn to manage array values
dave-redfern
reviewed
Jun 3, 2025
| @@ -44,6 +44,16 @@ public function check(mixed $value): bool | |||
| { | |||
| $this->assertHasRequiredParameters(['allowed_values']); | |||
|
|
|||
| if (is_array($value)) { | |||
There was a problem hiding this comment.
There is "AnyOf" that allows for validating an array of values are each within an array of allowed values. I am not sure how I feel about combining "In" to do both. I checked Laravels code and see that it does allow this, though "AnyOf" allows a string of delineated values as well.
| @@ -45,6 +45,16 @@ public function check(mixed $value): bool | |||
| { | |||
| $this->assertHasRequiredParameters(['disallowed_values']); | |||
|
|
|||
| if (is_array($value)) { | |||
There was a problem hiding this comment.
Based on the comments from In, I am not sure about combining this into the NotIn rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project I needed some new rules like prohibited_with, prohibited_with_all, prohibited_without, prohibited_without_all
I also needed to validate an array with the In rule, but this one wasn't accepting an array value, I modified it.
I have added translations but only french and english ones are actives, the other ones are commented because I have used a translation tool and I can't be sure they are correct.